Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 8 additions & 109 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,12 @@ members = [
"crates/perry-perex",
"crates/perry-ext-better-sqlite3",
"crates/perry-ext-zlib",
"crates/perry-ext-exponential-backoff",
"crates/perry-ext-events",
"crates/perry-ext-decimal",
"crates/perry-ext-moment",
"crates/perry-ext-cheerio",
"crates/perry-ext-sharp",
"crates/perry-ext-ethers",
"crates/perry-ext-nodemailer",
"crates/perry-ext-cron",
"crates/perry-ext-ioredis",
"crates/perry-ext-pg",
"crates/perry-ext-mysql2",
Expand All @@ -37,7 +34,6 @@ members = [
"crates/perry-ext-streams",
"crates/perry-ext-pdf",
"crates/perry-ext-ads",
"crates/perry-ext-node-forge",
"crates/perry-ext-parcel-watcher",
"crates/perry-ext-typescript",
"crates/perry-wasm-host",
Expand Down Expand Up @@ -465,15 +461,12 @@ perry-ext-argon2 = { path = "crates/perry-ext-argon2" }
perry-perex = { path = "crates/perry-perex" }
perry-ext-better-sqlite3 = { path = "crates/perry-ext-better-sqlite3" }
perry-ext-zlib = { path = "crates/perry-ext-zlib" }
perry-ext-exponential-backoff = { path = "crates/perry-ext-exponential-backoff" }
perry-ext-events = { path = "crates/perry-ext-events" }
perry-ext-decimal = { path = "crates/perry-ext-decimal" }
perry-ext-moment = { path = "crates/perry-ext-moment" }
perry-ext-cheerio = { path = "crates/perry-ext-cheerio" }
perry-ext-sharp = { path = "crates/perry-ext-sharp" }
perry-ext-ethers = { path = "crates/perry-ext-ethers" }
perry-ext-nodemailer = { path = "crates/perry-ext-nodemailer" }
perry-ext-cron = { path = "crates/perry-ext-cron" }
perry-ext-ioredis = { path = "crates/perry-ext-ioredis" }
perry-ext-pg = { path = "crates/perry-ext-pg" }
perry-ext-mysql2 = { path = "crates/perry-ext-mysql2" }
Expand All @@ -486,7 +479,6 @@ perry-ext-http = { path = "crates/perry-ext-http" }
perry-ext-streams = { path = "crates/perry-ext-streams" }
perry-ext-pdf = { path = "crates/perry-ext-pdf" }
perry-ext-ads = { path = "crates/perry-ext-ads" }
perry-ext-node-forge = { path = "crates/perry-ext-node-forge" }
perry-ext-parcel-watcher = { path = "crates/perry-ext-parcel-watcher" }
perry-ext-typescript = { path = "crates/perry-ext-typescript" }
perry-stdlib = { path = "crates/perry-stdlib" }
Expand Down
22 changes: 22 additions & 0 deletions changelog.d/10795-remove-cron-backoff-moment-forge.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
Removed the `cron`, `exponential-backoff`, `moment`, and `node-forge` native
bindings (`perry-ext-cron`, `perry-ext-exponential-backoff`,
`perry-ext-moment`, `perry-ext-node-forge`) — real npm source for all four
now compiles cleanly via `perry.compilePackages` and matches
`node --experimental-strip-types` byte-for-byte on a fixture exercising
each package's primary documented use (CronJob scheduling + CronTime
parsing; `backOff` retry/predicate/exhaustion paths; parse/format/
arithmetic/diff/duration; RSA keygen + X.509 build/sign/verify + PEM
round-trips). Each package's hidden `perry-stdlib`-side duplicate
implementation is removed too (`cron.rs`, `exponential_backoff.rs`,
`moment.rs`).

Five other packages probed in the same batch (`cheerio`, `ioredis`,
`nodemailer`, `undici`, `ws`) are **not** removed — each has a concrete,
reproduced blocker (see PR #10795): a callable-object-with-static-properties
invocation bug in cheerio's `$` factory; `ioredis`'s well-known binding key
and internal `Redis`-class dispatch key are shared load-bearing
infrastructure for `iovalkey`/`redis`, which are staying; nodemailer's
`class XOAuth2 extends Stream` against the bare `node:stream` `Stream`
still throws (confirms the #10649 follow-up gap); undici's `request()`
throws before attempting a TCP connect; and ws's `WebSocketServer` throws
right after a correct handshake, before the `'connection'` event fires.
18 changes: 5 additions & 13 deletions crates/perry-api-manifest/src/entries.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,11 @@ pub const NATIVE_MODULES: &[&str] = &[
"dns/promises", // (duplicate — kept for parity)
"url", // URL / URLSearchParams
// ── More third-party npm packages ──
"decimal.js", // arbitrary-precision decimals
"bignumber.js", // arbitrary-precision big numbers
"exponential-backoff", // retry-with-backoff helper
"lodash", // general utility library
"moment", // (legacy) date/time library
"sharp", // image processing (replaces the N-API addon)
"cheerio", // server-side jQuery-style HTML parsing
"cron", // cron scheduler (aliases node-cron)
"decimal.js", // arbitrary-precision decimals
"bignumber.js", // arbitrary-precision big numbers
"lodash", // general utility library
"sharp", // image processing (replaces the N-API addon)
"cheerio", // server-side jQuery-style HTML parsing
// ── Node.js builtins (cont.) ──
"async_hooks", // async context tracking
// #2875: internal module backing DisposableStack/AsyncDisposableStack
Expand Down Expand Up @@ -169,11 +166,6 @@ pub const NATIVE_MODULES: &[&str] = &[
"node-pty",
"bun-pty",
"@lydell/node-pty", // API-identical node-pty fork (see above)
// #466: node-forge PKI subset (RSA keygen, X.509 build/sign, PEM).
// Bundled wrapper at `crates/perry-ext-node-forge`; served natively
// for Socket Firewall's TLS-MITM CA so forge's pure-JS crypto isn't
// AOT-compiled.
"node-forge",
// @parcel/watcher's root binding and the eight published Node-API
// sidecars. HIR canonicalizes sidecars to the root dispatch table.
"@parcel/watcher",
Expand Down
11 changes: 0 additions & 11 deletions crates/perry-api-manifest/src/entries/part_1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1026,17 +1026,6 @@ pub(crate) const API_MANIFEST_PART_1: &[ApiEntry] = &[
),
method("nodemailer", "sendMail", true, None),
method("nodemailer", "verify", true, None),
// #4917 — real retry semantics: options (numOfAttempts/startingDelay/
// timeMultiple/maxDelay/delayFirstAttempt/jitter/retry) honored;
// Promise-returning tasks retry on rejection via promise reactions.
method_sig(
"exponential-backoff",
"backOff",
false,
None,
&[p_any("p0"), p_any("p1")],
TypeSpec::Any,
),
method_sig(
"argon2",
"hash",
Expand Down
Loading
Loading