Add diagnostic redaction regression tests#12
Open
fengyangxxx wants to merge 2 commits into
Open
Conversation
Notime02
added a commit
to Notime02/TentOfTrials
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1.
Adds focused diagnostic redaction regression coverage and the small build-script guards needed to keep diagnostic metadata reviewable: repository-relative paths, host identifier redaction, JSON-to-
.logdpairing validation, chunked artifact validation, and deterministic missing-tool diagnostics.This PR is scoped only to the diagnostic redaction/regression bounty.
Changes
diagnostic_logdreferences..logdartifacts, including chunked.logdparts.npmandcmaketools as module failures instead of crashing diagnostic generation.0c8d9252.Diagnostic artifacts
diagnostic/build-0c8d9252.jsondiagnostic/build-0c8d9252.logdThe diagnostic bundle was generated by running
python3 build.pyin a clean Linux container using the committedtools/encryptly/linux-x64/encryptlybinary. The JSON reportsdiagnostic_logd=diagnostic/build-0c8d9252.logd,chunked=false, nodiagnostic_logd_error, and nomessage_blocker.Testing
python3 -m unittest discover -s testspython3 build.py --listpython3 build.py.logdbundle.git diff --checkNotes