test(diagnostic): add redaction regression tests for build.py#17
Open
zjwjing wants to merge 1 commit into
Open
test(diagnostic): add redaction regression tests for build.py#17zjwjing wants to merge 1 commit into
zjwjing wants to merge 1 commit into
Conversation
Add 23 regression tests covering: - Path normalization (forward slashes, repo-relative, no Windows drive letters) - Sensitive data redaction (home, username, hostname, temp, full commit hash) - Artifact pairing (.logd reference matches actual file) - Missing file handling (clear failure when JSON/.logd missing or mismatched) - build.py integration (required functions, UTC timestamps, no hardcoded passwords) - Edge cases for cross-platform path normalization All 23 tests pass. Addresses Issue #1.
Author
|
Hi — following up on this PR. The refactored diagnostic redaction regression tests (23 tests, 6 test classes) are ready for review. Happy to address any feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add deterministic regression tests for diagnostic redaction, artifact pairing, and path normalization in build.py.
Changes
Checklist
Tests pass locally (23/23 OK)
Diagnostic build log is committed
I would like to request that my diagnostic build log is removed before merging