feat(keys): label hardware security-key identities - #125
Merged
Merged
Conversation
added 2 commits
September 18, 2026 12:51
Keys screen badges ed25519-sk/ecdsa-sk (generic sk fallback) via -sk/_sk path marker; ml-dsa no longer degrades to dsa badge. Tests: 4 keys-screen tests green (SK labels, unchanged regular labels, unknown-type fallback, card badge render incl. ssh -Q key oracle); full gate green. Connect-time presence/PIN deferred to hardware PoC per issue #80.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels hardware security-key identities on the keys screen: key paths carrying the ssh-keygen -t *-sk marker (-sk/_sk) now badge as ed25519-sk/ecdsa-sk (generic sk for unfamiliar bases) instead of the base algorithm. Also guards ml-dsa filenames so they no longer degrade to the dsa badge, and adds a CHANGELOG Unreleased entry.
Tests: 4 keys-screen tests green — SK label matrix, unchanged regular labels, unknown-type fallback to generic key, card badge render (with ssh -Q key oracle). Full gate green, snapshot taken.
Note: connect-time presence/PIN handling is deferred to the hardware PoC per issue #80.
Written by Muse Spark (Oh My Pi) on behalf of the maintainer.
Closes #80