Fix #51: replace placeholder security handles with concrete owners - #1
Open
Phantomcall wants to merge 3 commits into
Open
Fix #51: replace placeholder security handles with concrete owners#1Phantomcall wants to merge 3 commits into
Phantomcall wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Riddlrealm#51 — Replace placeholder security handles with concrete owners
Why it matters
Real handle = real triage; placeholder = silent failures. The previous
SECURITY.mdandCODEOWNERSused a placeholder email (security@mindmint.example)and a placeholder owner (
@Riddlrealm). Reports sent to these addresses arenever received, so vulnerabilities are discovered late or never.
Changes
SECURITY.mdsecurity@mindmint.examplewith the concretesecurity@mindmint.ioaddress.security@address soreports always reach the right team (placeholder/non-routed addresses cause
silent failures).
docs/SECURITY_RESPONSE_TIMELINE.md(SEV1–SEV3 acknowledge/triage/mitigation/post-mortem targets), satisfying the requirement to link that doc.
CODEOWNERS@Riddlrealmplaceholder with the real maintainer handle@Phantomcallacross all owned paths./SECURITY.mdand/CODEOWNERSso thesecurity policy and ownership file are themselves owned by the maintainer
team, matching the "mandate teams" acceptance criterion.
Acceptance criteria checklist
SECURITY.mdupdated.docs/SECURITY_RESPONSE_TIMELINE.mdlinked fromSECURITY.md.CODEOWNERSreflects mandate teams (real handle, security files owned).security@email address.Labels
area:security,kind:docs,priority:P1CI status — known pre-existing infra break (unrelated to this PR)
The
CI / buildandclippy / clippyworkflows are RED for all workspacepull requests, including this docs-only one. This is a pre-existing, repo-wide
dependency break in the test-only
soroban-env-host 21.2.1harness pulled bysoroban-sdk 21.7.7:ed25519-dalek 3.0.0requiresrand_core 0.10while itsChaCha20Rng(viarand 0.8.7) implementsrand_core 0.6.4, socargo check --workspace --all-targets/cargo clippy --workspace --all-targetsfail with
error[E0277]: ChaCha20Rng: ed25519_dalek::rand_core::CryptoRng is not satisfied.Cargo.lockis gitignored, so CI regenerates the broken resolution every run.The changes in this PR are correct (docs /
CODEOWNERSonly). Separate follow-up:bump
soroban-sdkor commit aCargo.lockpinning therand_core 0.6-compatiblecrypto stack.
closes Riddlrealm#51