Skip to content

Features/API-52/adjust-endpoints#82

Merged
andres15alvarez merged 15 commits into
devfrom
features/API-52/adjust-endpoints
Apr 29, 2025
Merged

Features/API-52/adjust-endpoints#82
andres15alvarez merged 15 commits into
devfrom
features/API-52/adjust-endpoints

Conversation

@iabrahaamxs
Copy link
Copy Markdown
Contributor

No description provided.

@iabrahaamxs iabrahaamxs added the feature New feature or request label Apr 24, 2025
@iabrahaamxs iabrahaamxs self-assigned this Apr 24, 2025
@iabrahaamxs iabrahaamxs marked this pull request as ready for review April 24, 2025 22:57
Copy link
Copy Markdown
Member

@andres15alvarez andres15alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valida tambien en los endpoints donde se crean o se editan que utilizaban el zipCode, que no truenen si se le manda, ya que en algunos DTO tenemos configurados que no reciba propiedades desconocidas, esto es para que el cambio no le rompa a frontend, simplmente ignoramos el zipCode cuando llegue y no lo guardamos en la base de datos porque ya no existe

Comment thread src/products/products.service.ts Outdated
Copy link
Copy Markdown
Member

@andres15alvarez andres15alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andres15alvarez
Copy link
Copy Markdown
Member

Vamos a hacer este merge en conjunto con su respectivo PR en el SDK, para que front solamente borre donde espera el zipCode

CarlosDev73
CarlosDev73 previously approved these changes Apr 26, 2025
@andres15alvarez andres15alvarez merged commit 187761f into dev Apr 29, 2025
2 checks passed
@andres15alvarez andres15alvarez deleted the features/API-52/adjust-endpoints branch April 29, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants