-
Notifications
You must be signed in to change notification settings - Fork 1
refactor button: add type prop and auto-disable on click #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
14987eb
button: add type prop and auto-disable on click
gus211 2f7a63d
Merge remote-tracking branch 'origin/dev' into refactor/button-auto-d…
gus211 c0ad7c6
Merge remote-tracking branch 'origin/dev' into refactor/button-auto-d…
gus211 32ffc3b
Merge remote-tracking branch 'origin/dev' into refactor/button-auto-d…
gus211 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { z } from 'zod'; | ||
|
|
||
| export const checkoutShippingInfoSchema = z | ||
| .object({ | ||
| shippingMethod: z.string().min(1, 'Debes seleccionar una opción de compra'), | ||
| branch: z.string().min(1, 'Debes seleccionar una sucursal/dirección'), | ||
| paymentMethod: z.string().min(1, 'Debes seleccionar un método de pago'), | ||
| }) | ||
| .refine( | ||
| () => { | ||
| // Aquí puedes poner cualquier lógica adicional si es necesario. | ||
| // Ejemplo: Si se selecciona "Envío a Domicilio", la dirección debe ser válida, etc. | ||
| return true; // Aquí se puede agregar lógica como validación de combinación de opciones | ||
| }, | ||
| { | ||
| message: | ||
| 'Por favor, asegurate de que todas las opciones estén bien seleccionadas', | ||
| path: ['shippingMethod', 'branch', 'paymentMethod'], // Asegura que todas las opciones estén bien seleccionadas | ||
| }, | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aca si es opcional el :? toma como que puede recibirse o no, creo que no hay que pasarle en si que tomara un tipo undefined, ya que es opcional de tomar alguno ya recibe una de las variantes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿Te refieres a que debería estar así
type?: 'submit' | 'reset' | 'button';?