Limit apriltag IDs (WIP)#2103
Draft
spacey-sooty wants to merge 16 commits intoPhotonVision:mainfrom
Draft
Conversation
github-actions
Bot
added
the
documentation
spacey-sooty
commented
Sep 23, 2025
github-actions
Bot
added
photonlib
spacey-sooty
force-pushed
the
limit-apriltag-ids
branch
from
a41ef65 to
4b9fa37
Compare
github-actions
Bot
added
frontend
spacey-sooty
force-pushed
the
limit-apriltag-ids
branch
from
2decf38 to
13540fe
Compare
spacey-sooty
force-pushed
the
limit-apriltag-ids
branch
2 times, most recently
from
7ea234a to
96edd3d
Compare
Member
Author
|
Need to do tests, documentation, sim and read from photonlib. |
Member
Author
|
also need to show that rejected detections are still detected with a different colour detection |
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
force-pushed
the
limit-apriltag-ids
branch
from
e28a358 to
651215d
Compare
samfreund
reviewed
Mar 27, 2026
|
|
||
| ## Accessing rejected tag info | ||
|
|
||
| Accessing rejected tag info is still important, as tags can serve other information not just localisation. For example in the 2025-2026 FTC Game, Decode, there was a tag utilised to determine different patterns of scoring elements. Mechanisms like this make it desirable to still have access to detection info even when we reject a tag for localisation purposes. |
Member
There was a problem hiding this comment.
Not sure how I feel about using an FTC example, does that imply support?
Member
Author
There was a problem hiding this comment.
I don't think it implies support. If someone has a different example I am happy to use that, it just seemed like the most obvious example as to why you might want to access some tag data even if its rejected
samfreund
reviewed
Mar 27, 2026
| <pv-input | ||
| v-model="currentPipelineSettings.rejectTagIds" | ||
| label="Reject Tag IDs" | ||
| tooltip="Tag IDs to reject for multitag estimation" |
Member
There was a problem hiding this comment.
add expected format to the tooltip (CSV)
samfreund
reviewed
Mar 27, 2026
| @update:modelValue="(value) => useCameraSettingsStore().changeCurrentPipelineSetting({ blur: value }, false)" | ||
| /> | ||
| <pv-input | ||
| v-model="currentPipelineSettings.rejectTagIds" |
Member
There was a problem hiding this comment.
v-model is a two-way bind, prefer creating a getter/setter for the v-model and removing @update:model-value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements tag filtering for AprilTag pipelines. See design doc for more info.
Meta
Merge checklist: