Add support for Green/Yellow status LEDs, like is used on some Limelights#2287
Open
thatcomputerguy0101 wants to merge 15 commits intoPhotonVision:2027from
Open
Add support for Green/Yellow status LEDs, like is used on some Limelights#2287thatcomputerguy0101 wants to merge 15 commits intoPhotonVision:2027from
thatcomputerguy0101 wants to merge 15 commits intoPhotonVision:2027from
Conversation
github-actions
Bot
added
documentation
thatcomputerguy0101
force-pushed
the
limelight-leds
branch
from
25f0ccc to
d2055ab
Compare
thatcomputerguy0101
force-pushed
the
limelight-leds
branch
from
d2055ab to
0f1eba1
Compare
Contributor
Author
|
I should probably also add a documentation section explaining the different color combinations. |
Contributor
Author
|
My hardware cooperated, and I confirmed everything here works as expected. IMG_1900.mov |
thatcomputerguy0101
force-pushed
the
limelight-leds
branch
3 times, most recently
from
10357f5 to
f8602e5
Compare
Contributor
Author
|
Documentation has been added, although the LED animations may be a little jank due to the weird interactions between MyST, Sphinx, Docutils, HTML, and SVG. |
Contributor
Author
|
There is the sphinx-contrib/imagesvg package that would eliminate the need for the zero-height image, but it doesn't support passing params around. |
thatcomputerguy0101
changed the title
gerth2
previously approved these changes
Mar 28, 2026
Contributor
gerth2
left a comment
gerth2
left a comment
There was a problem hiding this comment.
needs rebased and targeted toward 27.... I'm ok with this general direction and content though
thatcomputerguy0101
force-pushed
the
limelight-leds
branch
from
004933e to
bad03c0
Compare
github-actions
Bot
added
the
photonlib
Contributor
Author
|
Rebased, but I think the formatting on the 2027 branch isn't working right now. |
mcm001
reviewed
Mar 30, 2026
Contributor
mcm001
left a comment
mcm001
left a comment
There was a problem hiding this comment.
Code itself looks good to me, outside of a few nits! Sorry CI is totally broken on 2027 right now
github-actions
Bot
removed
the
photonlib
samfreund
force-pushed
the
2027
branch
2 times, most recently
from
f640d8d to
383f391
Compare
Contributor
|
I think it's worth avoiding JsonAlias if we're able to by changing names of things. |
samfreund
force-pushed
the
2027
branch
2 times, most recently
from
03a43cd to
68fc1e7
Compare
thatcomputerguy0101
force-pushed
the
limelight-leds
branch
2 times, most recently
from
d5a377e to
83371bf
Compare
thatcomputerguy0101
force-pushed
the
limelight-leds
branch
from
83371bf to
7aca9f1
Compare
thatcomputerguy0101
force-pushed
the
limelight-leds
branch
from
eb9e8b3 to
1c26be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support for other styles of status LEDs, starting with the Limelight Green-Yellow LEDs. LED indication was designed to match Limelight's as closely as possible within the limitation of PhotonVision's statuses. Additionally, I created a new documentation page explaining what the colors mean for both the RGB and the Green-Yellow status LED types.
IMG_1900.mov
For a future PR, I think it would be reasonable to implement addressable LED support, using the same colors as the regular RGB LED.
Meta
Merge checklist: