Skip to content

Add Community Contribution Guidelines#2405

Merged
gerth2 merged 6 commits intoPhotonVision:mainfrom
gerth2:more_dev_docs
Mar 27, 2026
Merged

Add Community Contribution Guidelines#2405
gerth2 merged 6 commits intoPhotonVision:mainfrom
gerth2:more_dev_docs

Conversation

@gerth2
Copy link
Copy Markdown
Contributor

@gerth2 gerth2 commented Mar 20, 2026

Description

Leadership team identified gaps in how we introduce new developers to the community.

Additional docs for onboarding new developers, helping clarify roles and what counts as a "good" PR.

Meta

Merge checklist:

  • [ X] Pull Request title is short, imperative summary of proposed changes
  • [ X] The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@gerth2 gerth2 requested a review from a team as a code owner March 20, 2026 13:08
@gerth2 gerth2 marked this pull request as draft March 20, 2026 13:08
@github-actions github-actions Bot added the documentation Anything relating to https://docs.photonvision.org label Mar 20, 2026
@mcm001
Copy link
Copy Markdown
Contributor

mcm001 commented Mar 20, 2026

These look good to me! Should they also be in the overall code of conduct for the organization? https://github.com/PhotonVision/.github/blob/master/codeofcoduct.md

@gerth2
Copy link
Copy Markdown
Contributor Author

gerth2 commented Mar 21, 2026

code of conduct

Possibly - Lemme ping ya on the side.

@gerth2 gerth2 marked this pull request as ready for review March 21, 2026 12:25
@samfreund
Copy link
Copy Markdown
Member

It might be good to include some sort of note about how PV support/discussion/etc. should always be public, and DMs won't be answered etc.

I don't think that necessarily fits here, but it could go in the CoC.

@gerth2
Copy link
Copy Markdown
Contributor Author

gerth2 commented Mar 27, 2026

@mcm001 @samfreund both comments addressed.

@gerth2 gerth2 enabled auto-merge (squash) March 27, 2026 02:02
@gerth2 gerth2 merged commit b5277e5 into PhotonVision:main Mar 27, 2026
59 checks passed
SpeedSlicer pushed a commit to SpeedSlicer/photonvision that referenced this pull request Mar 30, 2026
## Description

Leadership team identified gaps in how we introduce new developers to
the community.

Additional docs for onboarding new developers, helping clarify roles and
what counts as a "good" PR.

## Meta

Merge checklist:
- [ X] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [ X] The description documents the _what_ and _why_, including events
that led to this PR
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with all settings going back to the previous seasons's last release
(seasons end after champs ends)
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
- [ ] If this PR adds a dependency, the license has been checked for
compatibility and steps taken to follow it
cswilson252 pushed a commit to cswilson252/photonvision that referenced this pull request Apr 22, 2026
## Description

Leadership team identified gaps in how we introduce new developers to
the community.

Additional docs for onboarding new developers, helping clarify roles and
what counts as a "good" PR.

## Meta

Merge checklist:
- [ X] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [ X] The description documents the _what_ and _why_, including events
that led to this PR
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with all settings going back to the previous seasons's last release
(seasons end after champs ends)
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
- [ ] If this PR adds a dependency, the license has been checked for
compatibility and steps taken to follow it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants