refactor dark mode checks#2407
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Mar 24, 2026
Merged
Conversation
github-actions
Bot
added
the
frontend
mcm001
reviewed
Mar 24, 2026
mcm001
approved these changes
Mar 24, 2026
Gold856
reviewed
Mar 24, 2026
| <v-btn | ||
| color="buttonPassive" | ||
| :variant="theme.global.name.value === 'LightTheme' ? 'elevated' : 'outlined'" | ||
| :variant="theme.global.current.value.dark ? 'outlined' : 'tonal'" |
Contributor
There was a problem hiding this comment.
I don't think we meant to change this.
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Mar 24, 2026
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Mar 26, 2026
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Mar 26, 2026
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Mar 26, 2026
SpeedSlicer
pushed a commit
to SpeedSlicer/photonvision
that referenced
this pull request
Mar 30, 2026
The current method for checking light vs. dark mode is to compare the name of the theme against a hardcoded string. This PR uses a dark mode boolean. This change is for verbosity and so that we're not reliant on theme name. Additionally, we change some references to colors to the global theme, instead of indexing the list of themes.
cswilson252
pushed a commit
to cswilson252/photonvision
that referenced
this pull request
Apr 22, 2026
The current method for checking light vs. dark mode is to compare the name of the theme against a hardcoded string. This PR uses a dark mode boolean. This change is for verbosity and so that we're not reliant on theme name. Additionally, we change some references to colors to the global theme, instead of indexing the list of themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current method for checking light vs. dark mode is to compare the name of the theme against a hardcoded string. This PR uses a dark mode boolean. This change is for verbosity and so that we're not reliant on theme name. Additionally, we change some references to colors to the global theme, instead of indexing the list of themes.
Meta
Merge checklist: