Skip to content

Upgrade actions to Node 24 and remove unneeded archival#2416

Merged
samfreund merged 17 commits intoPhotonVision:2027from
samfreund:node-24
Apr 9, 2026
Merged

Upgrade actions to Node 24 and remove unneeded archival#2416
samfreund merged 17 commits intoPhotonVision:2027from
samfreund:node-24

Conversation

@samfreund
Copy link
Copy Markdown
Member

@samfreund samfreund commented Mar 27, 2026

Description

Since gh actions will be switching to Node 24 starting in June, we need to upgrade all our actions to node 24 versions.

The upload/download actions now support unzipped individual files, so we're migrating to use that where applicable. Note that this changes the names of some actions, which is why they are showing as missing checks.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@samfreund samfreund requested a review from a team as a code owner March 27, 2026 17:27
@samfreund samfreund changed the title Upgrade actions to node 24 Upgrade actions to Node 24 and remove unneeded archival Mar 28, 2026
@samfreund samfreund force-pushed the node-24 branch 3 times, most recently from 2618217 to df067a1 Compare March 28, 2026 04:05
@samfreund samfreund marked this pull request as draft March 28, 2026 04:20
@samfreund samfreund force-pushed the node-24 branch 4 times, most recently from 3b1bd90 to 8e49049 Compare March 28, 2026 07:17
@samfreund samfreund marked this pull request as ready for review March 29, 2026 20:31
samfreund and others added 10 commits April 3, 2026 13:12
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
## Description

Added systemcore to a couple of build files in order for `./gradlew
publishToMavenLocal` to generate systemcore-compatible dependencies.

Needed to support deploying photonlib to systemcore.

## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2024.3.1
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added

---------

Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
@samfreund samfreund changed the base branch from main to 2027 April 4, 2026 22:19
Copy link
Copy Markdown
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise seems reasonable

Comment thread .github/workflows/build.yml
@samfreund
Copy link
Copy Markdown
Member Author

Then we're just waiting for me to get the 2027 branch actually building

@samfreund samfreund merged commit 0e3f170 into PhotonVision:2027 Apr 9, 2026
19 of 31 checks passed
samfreund added a commit that referenced this pull request Apr 9, 2026
Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Co-authored-by: Jade Turner <spacey-sooty@proton.me>
Co-authored-by: Jordan McMichael <jlmcmchl@gmail.com>
samfreund added a commit to samfreund/photonvision that referenced this pull request Apr 9, 2026
…#2416)

Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Co-authored-by: Jade Turner <spacey-sooty@proton.me>
Co-authored-by: Jordan McMichael <jlmcmchl@gmail.com>
samfreund added a commit that referenced this pull request Apr 11, 2026
Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Co-authored-by: Jade Turner <spacey-sooty@proton.me>
Co-authored-by: Jordan McMichael <jlmcmchl@gmail.com>
cswilson252 pushed a commit to cswilson252/photonvision that referenced this pull request Apr 22, 2026
…#2416)

Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Co-authored-by: Jade Turner <spacey-sooty@proton.me>
Co-authored-by: Jordan McMichael <jlmcmchl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants