Skip to content

Use Platform.isAthena instead of manually checking for frcRunRobot.sh#2426

Merged
mcm001 merged 13 commits intoPhotonVision:2027from
amsam0:patch-1
Apr 9, 2026
Merged

Use Platform.isAthena instead of manually checking for frcRunRobot.sh#2426
mcm001 merged 13 commits intoPhotonVision:2027from
amsam0:patch-1

Conversation

@amsam0
Copy link
Copy Markdown

@amsam0 amsam0 commented Apr 7, 2026

Description

Use Platform.isAthena instead of manually checking for frcRunRobot.sh. This is just minor code cleanup. I made the change on GitHub's web editor; apologies if it doesn't compile.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

Gold856 and others added 10 commits April 6, 2026 14:26
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
## Description

Added systemcore to a couple of build files in order for `./gradlew
publishToMavenLocal` to generate systemcore-compatible dependencies.

Needed to support deploying photonlib to systemcore.

## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2024.3.1
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added

---------

Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
@amsam0 amsam0 requested a review from a team as a code owner April 7, 2026 19:45
Comment thread photon-targeting/src/main/java/org/photonvision/jni/CombinedRuntimeLoader.java Outdated
…#2416)

Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Co-authored-by: Jade Turner <spacey-sooty@proton.me>
Co-authored-by: Jordan McMichael <jlmcmchl@gmail.com>
@samfreund samfreund changed the base branch from main to 2027 April 9, 2026 16:10
@github-actions github-actions Bot added the website anything relating to https://photonvision.org label Apr 9, 2026
@mcm001 mcm001 merged commit a97449e into PhotonVision:2027 Apr 9, 2026
17 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website anything relating to https://photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants