Skip to content

Set raw exposure before setting auto exposure#2429

Merged
samfreund merged 1 commit intoPhotonVision:mainfrom
thatcomputerguy0101:Autoexposure-fix
Apr 10, 2026
Merged

Set raw exposure before setting auto exposure#2429
samfreund merged 1 commit intoPhotonVision:mainfrom
thatcomputerguy0101:Autoexposure-fix

Conversation

@thatcomputerguy0101
Copy link
Copy Markdown
Contributor

@thatcomputerguy0101 thatcomputerguy0101 commented Apr 10, 2026

Description

On Luma P1 and other devices, autoexposure on boot was getting overridden with the manual exposure setting. This was traced back to #1814, where the order of setting auto exposure and raw exposure was flipped. This flips it back.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@thatcomputerguy0101 thatcomputerguy0101 requested a review from a team as a code owner April 10, 2026 03:11
@github-actions github-actions Bot added the backend Things relating to photon-core and photon-server label Apr 10, 2026
@samfreund samfreund enabled auto-merge (squash) April 10, 2026 03:13
@samfreund
Copy link
Copy Markdown
Member

For future reference, this happened on multiple coprocs, not just Luma.

@thatcomputerguy0101
Copy link
Copy Markdown
Contributor Author

I tested this on a Luma P1 and found both autoexposure and manual exposure to be correctly set on boot.

@samfreund
Copy link
Copy Markdown
Member

I tested this on a Luma P1 and found both autoexposure and manual exposure to be correctly set on boot.

Same for a rubik pi, wasn't working previously.

@samfreund samfreund merged commit a5be3d0 into PhotonVision:main Apr 10, 2026
95 of 96 checks passed
cswilson252 pushed a commit to cswilson252/photonvision that referenced this pull request Apr 22, 2026
On a Luma P1, autoexposure on first boot was getting overridden with the manual exposure setting. This was traced back to PhotonVision#1814, where the order of setting auto exposure and raw exposure was flipped. This flips it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants