Set raw exposure before setting auto exposure#2429
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Apr 10, 2026
Merged
Set raw exposure before setting auto exposure#2429samfreund merged 1 commit intoPhotonVision:mainfrom
samfreund merged 1 commit intoPhotonVision:mainfrom
Conversation
samfreund
approved these changes
Apr 10, 2026
Member
|
For future reference, this happened on multiple coprocs, not just Luma. |
Contributor
Author
|
I tested this on a Luma P1 and found both autoexposure and manual exposure to be correctly set on boot. |
Member
Same for a rubik pi, wasn't working previously. |
cswilson252
pushed a commit
to cswilson252/photonvision
that referenced
this pull request
Apr 22, 2026
On a Luma P1, autoexposure on first boot was getting overridden with the manual exposure setting. This was traced back to PhotonVision#1814, where the order of setting auto exposure and raw exposure was flipped. This flips it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Luma P1 and other devices, autoexposure on boot was getting overridden with the manual exposure setting. This was traced back to #1814, where the order of setting auto exposure and raw exposure was flipped. This flips it back.
Meta
Merge checklist: