Skip to content

Raise minimum images for calibration to 100#2437

Open
spacey-sooty wants to merge 1 commit intoPhotonVision:2027from
spacey-sooty:update-minimum-images
Open

Raise minimum images for calibration to 100#2437
spacey-sooty wants to merge 1 commit intoPhotonVision:2027from
spacey-sooty:update-minimum-images

Conversation

@spacey-sooty
Copy link
Copy Markdown
Member

Description

We can see on
https://mrcal.secretsauce.net/docs-2.0/tour-choreography.html that more images appear to always be better, but diminishing returns kick in around 100 images. This shouldn't be too time consuming as a minimum and should get users the best effort to quality ratio so I think to makes sense as the default.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@spacey-sooty spacey-sooty requested a review from a team as a code owner April 22, 2026 02:23
@github-actions github-actions Bot added the frontend Having to do with PhotonClient and its related items label Apr 22, 2026
@spacey-sooty spacey-sooty requested a review from mcm001 April 22, 2026 02:23
samfreund
samfreund previously approved these changes Apr 22, 2026
@samfreund samfreund changed the base branch from main to 2027 April 22, 2026 02:23
@samfreund samfreund dismissed their stale review April 22, 2026 02:23

The base branch was changed.

We can see on
https://mrcal.secretsauce.net/docs-2.0/tour-choreography.html that more
images appear to always be better, but diminishing returns kick in
around 100 images. This shouldn't be too time consuming as a minimum and
should get users the best effort to quality ratio so I think to makes
sense as the default.
@samfreund samfreund force-pushed the update-minimum-images branch from 58c5d67 to c85b45f Compare April 22, 2026 02:23
@mdurrani808
Copy link
Copy Markdown
Contributor

This shouldn't be too time consuming

Is this true?

@samfreund
Copy link
Copy Markdown
Member

This shouldn't be too time consuming

Is this true?

I've done like 200 in 10 minutes or so, assuming you have someone else to click the button that's about a picture every three seconds. For only 100, that's a picture every six seconds.

@spacey-sooty
Copy link
Copy Markdown
Member Author

I quite comfortably did ~250 image calibrations in the pits at worlds in 2025 between matches so I don't see 100 being a huge barrier

@samfreund
Copy link
Copy Markdown
Member

Some sort of bypass option may be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants