Raise minimum images for calibration to 100#2437
Open
spacey-sooty wants to merge 1 commit intoPhotonVision:2027from
Open
Raise minimum images for calibration to 100#2437spacey-sooty wants to merge 1 commit intoPhotonVision:2027from
spacey-sooty wants to merge 1 commit intoPhotonVision:2027from
Conversation
samfreund
previously approved these changes
Apr 22, 2026
We can see on https://mrcal.secretsauce.net/docs-2.0/tour-choreography.html that more images appear to always be better, but diminishing returns kick in around 100 images. This shouldn't be too time consuming as a minimum and should get users the best effort to quality ratio so I think to makes sense as the default.
58c5d67 to
c85b45f
Compare
samfreund
approved these changes
Apr 22, 2026
Contributor
Is this true? |
Member
I've done like 200 in 10 minutes or so, assuming you have someone else to click the button that's about a picture every three seconds. For only 100, that's a picture every six seconds. |
Member
Author
|
I quite comfortably did ~250 image calibrations in the pits at worlds in 2025 between matches so I don't see 100 being a huge barrier |
Member
|
Some sort of bypass option may be useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can see on
https://mrcal.secretsauce.net/docs-2.0/tour-choreography.html that more images appear to always be better, but diminishing returns kick in around 100 images. This shouldn't be too time consuming as a minimum and should get users the best effort to quality ratio so I think to makes sense as the default.
Meta
Merge checklist: