Properly handle non-managed networking#2448
Open
mcm001 wants to merge 2 commits intoPhotonVision:mainfrom
Open
Properly handle non-managed networking#2448mcm001 wants to merge 2 commits intoPhotonVision:mainfrom
mcm001 wants to merge 2 commits intoPhotonVision:mainfrom
Conversation
Contributor
Author
|
Another option is wpilibsuite/allwpilib#8828 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous code did not handle various null cases, but more importantly, the non-managed device codepath was totally bjork if the server was not at localhost. This code path is only taken if networking is disabled, and I wasnt able to find any testing outside of localhost:
Changes
Meta
Merge checklist: