Skip to content

Mcp23008 drv 2#143

Merged
taartspi merged 12 commits into
masterfrom
mcp23008_drv_2
Jun 19, 2026
Merged

Mcp23008 drv 2#143
taartspi merged 12 commits into
masterfrom
mcp23008_drv_2

Conversation

@taartspi

@taartspi taartspi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

When reviewing, I don't see the expected state, I am doing this incorrectly >

[main] INFO com.pi4j.util.Console - LED on ??
[main] INFO com.pi4j.util.Console -  Pin 7state HIGH ?  true
[main] INFO com.pi4j.util.Console - Expect 0 Read Pin 7   value  1
[main] INFO com.pi4j.util.Console - Drive HIGH Pin 7
[main] INFO com.pi4j.util.Console -  Pin 7state HIGH ?  true
[main] INFO com.pi4j.util.Console - Expect 1 Read Pin 7   value  1
[main] INFO com.pi4j.util.Console - INTF register b00000000
[main] INFO com.pi4j.util.Console - INTF register b00000000
[main] INFO com.pi4j.util.Console -  Pin 3state HIGH ?  false
[main] INFO com.pi4j.util.Console - Expect 0 Read Pin 3   value  0
[main] INFO com.pi4j.util.Console - Expect console message pertaining to onDigitalStateChange when gpioToPin set High
[/dev/gpiochip0-event-detection-pin-27] INFO com.pi4j.util.Console - onDigitalStateChange Pin went low
[/dev/gpiochip0-event-detection-pin-27] INFO com.pi4j.util.Console - INTF register b10000011
[/dev/gpiochip0-event-detection-pin-27] INFO com.pi4j.util.Console - onDigitalStateChange Pin went high
[/dev/gpiochip0-event-detection-pin-27] INFO com.pi4j.util.Console

@stefanhaustein

stefanhaustein commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

When reviewing, I don't see the expected state, I am doing this incorrectly >

What's the expected state? Where specifically? This PR is multiple hundreds of lines...?

taartspi and others added 5 commits June 19, 2026 08:46
@taartspi
Merge branch 'master' into mcp23008_drv_2
ecbafcf
@taartspi
Remove empty printDefaultPlatform method
c343ad4 
Removed empty implementation of printDefaultPlatform method.
@taartspi
Update printLoadedPlatforms to use PrintInfo
2a280c5
@taartspi
Comment out printLoadedPlatforms call
e22c96c 
Comment out the call to printLoadedPlatforms in printLoadedPlatforms method.

Different PR removed this method. This file was missed. Eventually this entire file util will be removed
@taartspi
O
47cc974 
X
Omcp23008 using the driver

# Conflicts:
#	src/main/java/com/pi4j/devices/base_util/ffdc/FfdcLoggingSystem.java
#	src/main/java/com/pi4j/devices/base_util/ffdc/FfdcUtil.java
@taartspi taartspi merged commit 47cc4dd into master Jun 19, 2026
1 check passed
@taartspi taartspi deleted the mcp23008_drv_2 branch June 19, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taartspi @stefanhaustein