Merged
Conversation
195b798 to
004a901
Compare
Collaborator
|
What's up with |
* Fix submodule CMake to enable colcon build with the ninja and debug mixins
004a901 to
56aef0b
Compare
Author
Without that, the linking fails because of some missing symbols. This seems like the nonsense we dealt with earlier where it looks like some compiler optimization routine is removing symbols for something we end up needing |
Author
|
If it's too ugly I can look into a more elegant solution. Maybe a better way to do this would be to just add the covariance_geometry_cpp repo as a submodule inside of covariance_geometry_ros (rather than pulling it in via CMake FetchContent) and hope that the compiler will realize not to strip those symbols in that case |
henrygerardmoore
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change my build fails if I try colcon build --mixin debug ninja
To test: make sure everything builds successfully with colcon build --mixin release ninja and colcon build --mixin debug ninja