Pilot 6552: update upload preupload logic to batchly create resumable_info.json#207
Merged
Pilot 6552: update upload preupload logic to batchly create resumable_info.json#207
resumable_info.json#207Conversation
Contributor
afmam
approved these changes
Mar 19, 2025
Member
afmam
left a comment
There was a problem hiding this comment.
Thanks for making the changes! LGTM
colorzzr
added a commit
that referenced
this pull request
Mar 27, 2025
* Pilot 7101: Update the message of new version notification (#210) * build on testing * build on testing * remove the testing code * update new version notification * remove the testing pipeline * Pilot 6552: update upload preupload logic to batchly create `resumable_info.json` (#207) * update manifest logic to output resumable information after each batch * update test cases for new resumable upload files * bumpup version * update PR * fixup test cases due to new output * merged * Pilot 7234: Add git actions to automatically extract compatible version from PR into release note and README (#216) * Pilot 7234: add pipeline to automatically extract compatible version to README and Release Note (#211) * test on git actions * test on git actions * Updated compatible_version.md with PR # * test actions on pull request * test actions on pull request * update git actions * Updated docs/compatible_version.md with PR # * testing * Updated docs/compatible_version.md with PR # * modify the pipeline file --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Updated docs/compatible_version.md with PR #211 * embed the compatible table into README.md * embed the compatible table into README.md (#212) * Updated docs/compatible_version.md with PR #212 * add pipeline to add version in cli binary release * Patch20250318 (#213) * embed the compatible table into README.md * add pipeline to add version in cli binary release * Updated docs/compatible_version.md with PR #213 * fixup the table will truncate the readme * Patch20250318: fixup the table will truncate the readme (#214) * embed the compatible table into README.md * add pipeline to add version in cli binary release * fixup the table will truncate the readme * Updated docs/compatible_version.md with PR #214 * add PR related in build and publish * remove the testing branch * update compatible version as NDJSON format for later api design * update compatible version as NDJSON format for later api design --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update git action (#221) * use github actions as commit user --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
colorzzr
added a commit
that referenced
this pull request
Mar 27, 2025
* Pilot 7101: Update the message of new version notification (#210) * build on testing * build on testing * remove the testing code * update new version notification * remove the testing pipeline * Pilot 6552: update upload preupload logic to batchly create `resumable_info.json` (#207) * update manifest logic to output resumable information after each batch * update test cases for new resumable upload files * bumpup version * update PR * fixup test cases due to new output * merged * Pilot 7234: Add git actions to automatically extract compatible version from PR into release note and README (#216) * Pilot 7234: add pipeline to automatically extract compatible version to README and Release Note (#211) * test on git actions * test on git actions * Updated compatible_version.md with PR # * test actions on pull request * test actions on pull request * update git actions * Updated docs/compatible_version.md with PR # * testing * Updated docs/compatible_version.md with PR # * modify the pipeline file --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Updated docs/compatible_version.md with PR #211 * embed the compatible table into README.md * embed the compatible table into README.md (#212) * Updated docs/compatible_version.md with PR #212 * add pipeline to add version in cli binary release * Patch20250318 (#213) * embed the compatible table into README.md * add pipeline to add version in cli binary release * Updated docs/compatible_version.md with PR #213 * fixup the table will truncate the readme * Patch20250318: fixup the table will truncate the readme (#214) * embed the compatible table into README.md * add pipeline to add version in cli binary release * fixup the table will truncate the readme * Updated docs/compatible_version.md with PR #214 * add PR related in build and publish * remove the testing branch * update compatible version as NDJSON format for later api design * update compatible version as NDJSON format for later api design --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update git action (#221) * use github actions as commit user * directly parse of version from .toml file --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the preupload logic will generate
resumable_info.jsonafter all preupload finished. But if any batch raises error or gets interrupted, users will lose current upload completely. To resolve this, cli add a new field to keep trackunregistered_itemat local and updateresumable_info.jsonper batch:JIRA Issues
PILOT_6552
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
add test cases to make sure outputs contains
unregistered_items