feat(review): reorder single-goal details display (#229)#285
Merged
Conversation
Reorder formatGoalDetails to lead with the goal's commitment (Rate, Autoratchet), then urgency (Limsum, Deadline, Due time), then stakes (Pledge), then reference (Title, URL) — matching the preferred order in issue #229. Fields the issue didn't enumerate (Autodata, Fine print, recent datapoints) follow, preserving that sequence. Add TestGoalDetailsFieldOrder to lock the ordering in. Closes #229 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: PinePeakDigital/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReorders the field emission in formatGoalDetails: Rate and Autoratchet are emitted first, then limsum/deadline/pledge, followed by Title, URL, and Autodata. Adds two tests that assert labels appear (or are omitted) and that present labels follow the required relative ordering. ChangesGoal Detail Field Ordering
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🚀 Pre-release Build ReadyTest builds are ready! Install directly using the # Install the pre-release
bin install https://github.com/PinePeakDigital/buzz/releases/tag/pr-285-latest buzz-pr-285# Run the pre-release
buzz-pr-285# Uninstall the pre-release
bin remove buzz-pr-285Direct Download LinksOr download binaries directly from the pre-release page:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the single-goal details rendering to match the field ordering requested in issue #229, affecting the shared formatGoalDetails output used by both buzz review and buzz view.
Changes:
- Reordered the per-goal detail lines to: Rate → Autoratchet → Limsum → Deadline → Due time → Pledge → Title → URL, with Autodata/Fine print/recent datapoints following after.
- Kept the existing rate formatting behavior (including current vs end rate display) while moving it to the top of the details section.
- Added a regression test to lock in the intended label ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| review.go | Reorders formatGoalDetails output fields to match issue #229’s preferred sequence. |
| review_test.go | Adds TestGoalDetailsFieldOrder to assert the exact relative order of labels in the formatted output. |
review-loop coverage finding (auto-applied, low-risk test-only): TestGoalDetailsFieldOrderMinimal asserts the #229 field order is preserved and Rate/Autoratchet/Title/Autodata/Fine print are omitted when unset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorders the per-goal field display in
buzz reviewto the sequence requested in #229. Fresh implementation against currentmain(the prior Copilot draft #230 predates the recentreview.gorework and no longer applies cleanly).Screenshot
buzz reviewshowing the new field order (Rate → Autoratchet → Limsum → Deadline → Due time → Pledge → Title → URL, then Autodata):Order
Issue #229's preferred sequence, implemented exactly for the named fields:
Fields the issue didn't enumerate follow after, preserving that order: Autodata, Fine print, then recent datapoints. (Heads-up: this moves Autodata from mid-list down to the reference group — say the word if you'd rather it sit elsewhere.)
Rationale
Leads with the goal's commitment (rate, autoratchet), then urgency (limsum, deadline, due time), then stakes (pledge), then reference info (title, url).
Tests
TestGoalDetailsFieldOrderasserts the exact relative order of all labels.TestFineprintOrderInOutputstill holds (fine print stays after URL).go vet,gofmtall clean.Closes #229
🤖 Generated with Claude Code
Summary by CodeRabbit