Skip to content

fix(tikv/rust-rocksdb): migrate CI from CentOS 7 to Rocky Linux 8 #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 1 commit into from
Apr 29, 2026
Merged

fix(tikv/rust-rocksdb): migrate CI from CentOS 7 to Rocky Linux 8 #4564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions prow-jobs/tikv/rust-rocksdb/latest-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ presubmits:
- amd64
containers:
- name: rust
image: ghcr.io/pingcap-qe/cd/builders/tikv:v2025.12.14-1-g33e22ac-centos7-devtoolset8
image: ghcr.io/pingcap-qe/cd/builders/tikv:v2026.3.22-3-g892e449
command: [bash, -ce]
args:
- |
Expand All @@ -38,11 +38,7 @@ presubmits:

# Check C++ formatting
if ! command -v clang-format &> /dev/null; then
# CentOS 7 uses yum and llvm-toolset-7.0
yum install -y llvm-toolset-7.0
if [ -f /opt/rh/llvm-toolset-7.0/enable ]; then
source /opt/rh/llvm-toolset-7.0/enable
fi
dnf install -y clang-tools-extra

@gemini-code-assist gemini-code-assist Bot Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the general rules, dependencies should be baked into the Docker image instead of being installed at runtime in CI scripts to improve performance and reliability. Since openssl-devel is already pre-installed in the new Rocky Linux 8 image, consider also baking clang-tools-extra (which provides clang-format) into the image and removing this runtime installation block.

References
  1. For better CI performance and reliability, bake dependencies into the Docker image instead of installing them at runtime in CI scripts.

fi
find librocksdb_sys/crocksdb/ \( -iname "*.h" -o -iname "*.cc" \) | while read f; do
diff -q <(clang-format "$f") "$f" || (echo "❌ $f" && exit 1)
Expand Down Expand Up @@ -72,7 +68,7 @@ presubmits:
- amd64
containers:
- name: rust
image: ghcr.io/pingcap-qe/cd/builders/tikv:v2025.12.14-1-g33e22ac-centos7-devtoolset8
image: ghcr.io/pingcap-qe/cd/builders/tikv:v2026.3.22-3-g892e449
command: [bash, -ce]
env:
- name: RUST_BACKTRACE
Expand All @@ -82,12 +78,6 @@ presubmits:
#!/usr/bin/env bash
set -exo pipefail

yum install -y openssl-devel

# Setup GCC 8
if [ -f /opt/rh/devtoolset-8/enable ]; then
source /opt/rh/devtoolset-8/enable
fi
g++ --version
cmake --version

Expand Down Expand Up @@ -149,7 +139,7 @@ presubmits:
- arm64
containers:
- name: rust
image: ghcr.io/pingcap-qe/cd/builders/tikv:v2025.12.14-1-g33e22ac-centos7-devtoolset8
image: ghcr.io/pingcap-qe/cd/builders/tikv:v2026.3.22-3-g892e449
command: [bash, -ce]
env:
- name: RUST_BACKTRACE
Expand All @@ -159,12 +149,6 @@ presubmits:
#!/usr/bin/env bash
set -exo pipefail

yum install -y openssl-devel

# Setup GCC 8
if [ -f /opt/rh/devtoolset-8/enable ]; then
source /opt/rh/devtoolset-8/enable
fi
g++ --version
cmake --version

Expand Down