Fix power monitoring test shutdown signal mismatch - #57
Merged
Conversation
The EXPERIMENT_END_SIGNAL was set to 'test-end-signal' but the sample data uses '6e153711-9823-4ee6-b608-58e2e801db51'. This caused the daemon to never detect the shutdown signal and never process power summary data. Changes: - Update EXPERIMENT_END_SIGNAL to match sample data UUID - Increase wait time for power data to flow through pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the power monitoring test failure where
total_cpu_power_consumptionandtotal_gpu_power_consumptionproperties were not found in the Deployment node.Root Cause
The
EXPERIMENT_END_SIGNALenvironment variable was set totest-end-signal, but the sample data (image_mapping_final.json) uses the UUID6e153711-9823-4ee6-b608-58e2e801db51as the shutdown signal.This caused the daemon to:
process_summary_events()to send power data to KafkaChanges
EXPERIMENT_END_SIGNALto match the UUID in sample dataTest plan
test_power_monitoring_truetotal_cpu_power_consumptionandtotal_gpu_power_consumption