patch(ranking): remove group rank changes when ranking provider is set to none

components/profile/book.tsx

@@ -66,10 +66,12 @@ const Book: FC<Props> = ({ userBook, onRefetch, logbookPermissions, isSelf }) =>
         const response = await axios.get(
           `/api/workspace/${id}/external/ranking`
         );
-        setRankingEnabled(
-          response.data.rankGunEnabled ? response.data.rankGunEnabled : response.data.openCloudEnabled ? response.data.rankGunEnabled : false
+        const enabled = Boolean(
+          response.data.rankingEnabled ??
+            (response.data.rankGunEnabled || response.data.openCloudEnabled)
         );
-        return response.data.rankGunEnabled ? response.data.rankGunEnabled : response.data.openCloudEnabled ? response.data.rankGunEnabled : false;
+        setRankingEnabled(enabled);
+        return enabled;
       } catch (error) {
         return false;
       }

components/settings/instance/external.tsx

@@ -271,6 +271,12 @@ const ExternalServicesImpl: FC<ExternalServicesProps> = ({
               </option>
             ))}
           </select>
+          {!rankingProvider && (
+            <p className="mt-1.5 text-[11px] leading-relaxed text-zinc-400 dark:text-zinc-500">
+              Promotion, demotion, and termination logs will not change ranks in
+              the Roblox group.
+            </p>
+          )}
         </div>
 
         {rankingProvider === "rankgun" && (

pages/api/workspace/[id]/external/ranking.ts

@@ -1,7 +1,7 @@
 import type { NextApiRequest, NextApiResponse } from "next";
 import { withPermissionCheck } from "@/utils/permissionsManager";
 import { getRankGun } from "@/utils/rankgun";
-import { getConfig } from "@/utils/configEngine";
+import prisma from "@/utils/database";
 
 export default withPermissionCheck(handler, "rank_users");
 
@@ -22,11 +22,19 @@ async function handler(req: NextApiRequest, res: NextApiResponse) {
   try {
     const workspaceGroupId = parseInt(id as string);
     const rankGun = await getRankGun(workspaceGroupId);
-    const openCloudConfig = await getConfig("roblox_opencloud", workspaceGroupId)
+    const external = await prisma.workspaceExternalServices.findFirst({
+      where: { workspaceGroupId },
+    });
+    const openCloudEnabled =
+      external?.rankingProvider === "opencloudranking" &&
+      typeof external.rankingToken === "string" &&
+      external.rankingToken.length > 0;
+    const rankingEnabled = !!rankGun || openCloudEnabled;
     return res.status(200).json({
       success: true,
       rankGunEnabled: !!rankGun,
-      openCloudEnabled: !!openCloudConfig.enabled
+      openCloudEnabled,
+      rankingEnabled,
     });
   } catch (error) {
     return res.status(500).json({

pages/api/workspace/[id]/settings/external.ts

@@ -102,7 +102,11 @@ async function handler(req: NextApiRequest, res: NextApiResponse) {
         updatedAt: new Date(),
       };
 
-      if (clearRankingToken) {
+      if (!rankingProvider) {
+        updatePayload.rankingToken = null;
+        updatePayload.rankingWorkspaceId = null;
+        updatePayload.rankingMaxRank = null;
+      } else if (clearRankingToken) {
         updatePayload.rankingToken = null;
       } else if (tokenTrim !== "") {
         updatePayload.rankingToken = tokenTrim;