HOTFIX: update on 3.3.7#90
Merged
sifex merged 8 commits intoJan 23, 2026
Merged
Conversation
Push to v3 Branch
Rolled back on adding an additional constructor to ensure backwards compatibility
# Conflicts: # src/BunnyCDNAdapter.php # tests/FlysystemAdapterTest.php # tests/PrefixTest.php
chrispage1
force-pushed
the
feature/temporary-urls
branch
from
bddbbad to
a8d09af
Compare
Contributor
Author
|
Not sure what is going on with the tests as passing locally. It seems like the tests are retaining some old tests which are no longer present? |
Collaborator
|
No problems, thanks for the hotfix, I yanked 3.3.7, so feel free to have time to get all tests passing and I'll merge in and publish a 3.3.8 😊 |
Collaborator
|
Hmm, let me check the tests |
sifex
reviewed
Jan 23, 2026
Collaborator
There was a problem hiding this comment.
I've added the fix for the CI failures:
Changes:
- Updated PHPUnit from
@stableto^10.0for consistency (Comment annotations got removed in PHP Unit 12) - Added conditional skip for
generating_a_temporary_url()test in mock environments - Updated the PHP version's to match 2026 compat: https://www.php.net/supported-versions.php
Collaborator
|
Lmk if you're happy with the PR and I'll merge 😊 |
Contributor
Author
|
Ah great stuff! I'm happy now. I wrote a new test suite for temporary just to avoid any confusion! Sorry for the bad PR initially! |
Collaborator
|
Hang on, sorry, one more, can probably bring your tests back now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sifex
I noticed this introduced a breaking change whereby it was accepting three constructor parameters.
This fix rolls back on that slightly and instead accepts a method to set the signing key