Fix Unreal Engine 5.8 JSON key handling - #100
Draft
Nick Lombardi (nkmlombardi) wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Convert the shared JSON member-name values to the string-view form expected by Unreal Engine 5.8 before passing them to
FJsonObject.Why
UE 5.8 no longer accepts the existing shared-string key values at these call sites, which prevents
OnlineSubsystemPlayFab2.3.8 from compiling. This is a source compatibility migration only; JSON names and runtime behavior are unchanged.Validation
Packaged
OnlineSubsystemPlayFab2.3.8 against an Unreal Engine 5.8 source build for Editor, Development, and Shipping configurations.