Fix log severity: LocalChatUser nullptr is Verbose not Error on GDK - #92
Open
Maryam (maryammadzadeh) wants to merge 1 commit into
Open
Conversation
Matches ChatPermissionTracking.Win.cpp which logs the same condition at Verbose. LocalChatUser being null during Logging it at Error caused 30Hz spam in shipped logs whenever a remote talker was registered before the local talker completed registration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches ChatPermissionTracking.Win.cpp which logs the same condition at Verbose. LocalChatUser being null during
Logging it at Error caused 30Hz spam in logs
Unreal only prints above the currently enabled log level. So that's why we see spam.