Repository navigation
feat: replay a recorded response, starting with the Responses API - #12
Merged
Merged
Conversation
A scenario can now come from a recorded provider stream in kartsan03/wiretruth's wiretruth.fixture/v1 format, not only from code. The first is openai/responses-stream-missing-finish-abort, vendored unchanged with its derived_from block and the MIT notice: eight Responses API events, then the connection drops. It is also the first Responses API scenario, so the app calls client.responses.create and the reference instrumentation covers it. The fake provider never dropped a connection when drop_after equalled the event count: the loop ended first and sent a clean end of stream. A recorded abort cuts after its last frame, so the drop now happens after the loop. Fixes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replays a recorded provider stream as a scenario. The first one is the first OpenAI Responses API scenario: kartsan03/wiretruth's
stream.missing-finish-abort, vendored unchanged with itsderived_fromblock and MIT notice. It holds eight recorded events, and then the connection drops.It also fixes the fake provider. When
drop_afterequalled the number of events, it ended the stream cleanly instead of dropping the connection.All three libraries end the Responses span with an error. OpenLLMetry 0.62.4 still leaves the Chat Completions span OK on the same failure (traceloop/openllmetry#4535).
Fixes #11