Renamed UNIXSocketType enum and added ALL_PARAMETERS interface configuration definition.#323
Renamed UNIXSocketType enum and added ALL_PARAMETERS interface configuration definition.#323adamshapiro0 wants to merge 13 commits intomasterfrom
UNIXSocketType enum and added ALL_PARAMETERS interface configuration definition.#323Conversation
adamshapiro0
force-pushed
the
all-params
branch
3 times, most recently
from
c077d3f to
5dbecdd
Compare
axlan
left a comment
axlan
left a comment
There was a problem hiding this comment.
This is missing the Python implementation, which is probably going to be non-trivial. Similarly, the Nautilus implementation may be a little complicated since it's going to need to return multiple memory segments, which we've done for wheel speed, but I'm not sure we've done for the interface settings.
adamshapiro0
force-pushed
the
all-params
branch
2 times, most recently
from
222c606 to
4e35913
Compare
|
@axlan added Python implementation and resolved a few related issues. Please take another look. |
adamshapiro0
force-pushed
the
position-error
branch
from
fcfe025 to
c9fc070
Compare
| uint8_t enabled = 1; | ||
| TransportDirection direction = TransportDirection::SERVER; | ||
| uint16_t port = 0; | ||
| char remote_address[64] = {0}; |
There was a problem hiding this comment.
its odd to call this remote address if this represents a server and a client. My personal opinion is that TCPServer and TCPClient should be treated as two different top level entities. There is no such thing as a remote address on a TCP server and if its intended to be the bind_address, it should be named as such.
anathan
left a comment
anathan
left a comment
There was a problem hiding this comment.
overall the name changes make sense.
adamshapiro0
force-pushed
the
all-params
branch
2 times, most recently
from
31b0cfd to
7a89556
Compare
adamshapiro0
force-pushed
the
all-params
branch
from
7a89556 to
03e7da9
Compare
adamshapiro0
force-pushed
the
all-params
branch
from
03e7da9 to
80a1c84
Compare
adamshapiro0
force-pushed
the
all-params
branch
2 times, most recently
from
dce9cfe to
b8321cc
Compare
adamshapiro0
force-pushed
the
all-params
branch
from
b8321cc to
8976589
Compare
adamshapiro0
force-pushed
the
all-params
branch
from
8976589 to
c08304b
Compare
3 participants
New Features
InterfaceConfigType::ALL_PARAMETERSand config structs (e.g.,TCPConfig) to allow bulk configuration of a transportGetConfigMessage(interface=)argument for ease of use, consistent withSetConfigMessageChanges
SocketTypetoUNIXSocketTypefor clarityFixes
TransportDirectionandSocketTypevalues