feat: add copy identifier shortcut#769
Open
Green00101 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a keyboard shortcut (
Ctrl + Shift + C,Option + Shift + Con macOS) to copy the current entity identifier.CopyIdentifiercomponent, so all pages with a copy identifier button support it and the copied value is identical to the button's output.Closes #761
Note before testing
macOS was not tested, because I don't have a Mac device.
Tests to perform
Ctrl + Shift + C: a single success notification appears and the clipboard contains the identifier with the:prefix (e.g.:bulbasaur), identical to the copy button output.:prefix.Ctrl + Left/Right) then press the shortcut: the new entity's identifier is copied.These are the tests I performed. Please let me know if there are any additional cases I should check.