Implement line2points in mapbrowser.js - #63
Merged
Conversation
Copilot created this pull request from a session on behalf of
ohanssen
July 14, 2026 13:27
View session
ohanssen
marked this pull request as ready for review
July 14, 2026 13:29
There was a problem hiding this comment.
Pull request overview
This PR implements line2points() in mapbrowser.js, replacing the previous stub with a geodesic-based interpolation that generates evenly spaced points (in meters) between two lon/lat coordinates using OpenLayers sphere utilities.
Changes:
- Implements distance computation via
ol.sphere.getDistance(from, to). - Computes initial bearing and uses
ol.sphere.offset()to generate points at fixed meter intervals along the great-circle path. - Adds basic edge-case handling for invalid/non-positive
distanceand coincident endpoints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line2pointswas a stub (/* TBD */) with no implementation.Changes
ol.sphere.offsetto place points at exact meter intervals along the great-circle arc — avoids the distortion of linear lon/lat interpolationol.sphere.getDistancefor the total arc length between endpoints[]for invalid/non-positive distance,[from]whenfrom === toMath.ceil+Math.minclamp so bothfromandtoare always included without duplicates regardless of divisibility