Fix line2points to always return strict [longitude, latitude] point arrays - #64
Merged
Conversation
Copilot created this pull request from a session on behalf of
ohanssen
July 15, 2026 10:36
View session
ohanssen
marked this pull request as ready for review
July 15, 2026 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line2pointswas documented to return[[longitude, latitude], ...]but the zero-distance edge case returned[from]directly — passing through the raw input coordinate which may carry extra dimensions (e.g. a 3D[lon, lat, altitude]coordinate).Change
totalDist === 0edge case (mapbrowser/mapbrowser.js): replacedreturn [from]withreturn [[from[0], from[1]]]to explicitly construct a 2-element[longitude, latitude]pair, consistent with the output of every other code path (the main loop already produces correct 2-element arrays viaol.sphere.offset).