Build a focused household journey and editable results page - #129
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MaxGhenis
marked this pull request as ready for review
September 9, 2026 11:44
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calculator previously returned users from guided setup to the original sidebar form. This change gives setup and results distinct purposes: focused questions collect household details, then a full-width results page shows a compact, editable household summary.
Each Edit action opens one topic. Save recalculates from the complete household, while Cancel or Escape keeps the current result and shared link. The flow asks about childcare only when relevant, separates UK housing and finances, and preserves entered ages when changing countries. Existing shared links open results directly.
A new “What changes” section explains the largest financial effects using the same program breakdown as the tables and selected income-grid cell. Healthcare and early education service values remain separate from financial resources.
Validation: 268 frontend tests and 38 backend tests pass; production build and lint pass (existing warnings remain). Browser checks cover desktop and mobile setup, section editing, Save, shared family results, and UK setup. The calculation backend and model versions are unchanged.
Independent code review is complete with no remaining findings. Six targeted validation reproductions pass; browser checks confirm that tall editors cover shared navigation and their dropdowns remain usable.