This repository was archived by the owner on Jul 6, 2026. It is now read-only.
OBBBA household explorer banner on homepage - #2689
Closed
SakshiKekre wants to merge 12 commits into
Closed
SakshiKekre wants to merge 12 commits into
SakshiKekre wants to merge 12 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
One comment: at breakpoints below about 1000px, some of the text splays across the dome, making it harder to read. Unsure on the intended design, but can we put something behind the text to make it readable across all breakpoints? |
SakshiKekre
force-pushed
the
add-obbba-explorer-as-banner
branch
from
July 24, 2025 22:33
5089a35 to
f9bd50e
Compare
Collaborator
|
I'd recommend squaring off the edges of the text background box to match the rest of the theme. Otherwise, this looks good to me, but curious if @MaxGhenis has strong opinions regarding the Capitol dome not being visible at breakpoints below 900px. |
MaxGhenis
approved these changes
Jul 25, 2025
MaxGhenis
left a comment
MaxGhenis
left a comment
Contributor
There was a problem hiding this comment.
Thanks, we'll merge when we launch (now Monday)
Collaborator
Author
|
Closing as the banner is no longer needed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2687