-
Notifications
You must be signed in to change notification settings - Fork 10
POLIPHON 2 - first part #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
HolgerPollyNet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obviously you have not used the latest dev version, there are things in the dev branch which are not in your code
lib/interface/picassoProcV3.m
Outdated
| print_msg('Start searching polly campaign information and polly configurations.\n', 'flagTimestamp', true); | ||
| try | ||
| [PollyConfig, CampaignConfig] = searchCampConfig(pollyDataFile, pollyType, PicassoConfig.pollynet_config_link_file); | ||
| [~, fName, fExt] = fileparts(pollyDataFile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this cryptic line for?
I think this happened because we copied the old main file instead of adding the respective POLIPHON 2 part. @jn76lewy could you please just add the POLIPHON 2 lines in the current picassoProcV3.m file and then push this file only again? |
|
@HolgerPollyNet could you please check again? @jn76lewy has just pushed the correct version of the main script! |
|
Looks good. I will switch to his branch on rsd2 for some testing. Any objections @ulysses78 ? |
|
I get the following error on rsd2: Index in position 2 exceeds array bounds. Index must not exceed 4000. Error in poliphon_two (line 154) Error in picassoProcV3 (line 3292) Error in picassoProcTodolist (line 62) Any idea? |
n is the height index, which indeed should not exceed 4000. I do not know why it does in this case- which station/date did you try? Maybe @jn76lewy can run locally the same case to examine more closely why it happens |
@jn76lewy, the issue is on how we currently create the mr variable (line 129: mr = (0:2.500625156289073e-04:1);) I quickly tested the following lines, they should work: You could try it locally & if it runs through properly, then push the updated poliphon_2 function only. |
|
@HolgerPollyNet Try once more please |
|
i change the code and it worked for me locally |
|
its currently running on rsd2, so far without problems ;-) |
Nice!! You can have a look at the new nc file and tell us if the variables names etc are ok or if something needs to be changed! |
|
I think the updated global config with the new keyword for saving is missing...but I added it manually.... |
|
Thanks! We will also take care of the visualization together with @ulysses78 soon |

Here comes the separation part of the 2nd POLIPHON step. Have a look and let Jonas know if anything needs to be changed!