Skip to content

Revert "Fix verifier not verifying" #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hczphn wants to merge 1 commit into from
+8 −33
Closed

Revert "Fix verifier not verifying" #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 8 additions & 33 deletions gkr/src/verifier/snark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ impl<'a, Cfg: GKREngine> Verifier<'a, Cfg> {
proving_time_mpi_size: usize,
) -> <Cfg::PCSConfig as ExpanderPCS<Cfg::FieldConfig>>::Commitment {
let timer = Timer::new("pre_gkr", true);

let commitment =
<<Cfg::PCSConfig as ExpanderPCS<Cfg::FieldConfig>>::Commitment as ExpSerde>::deserialize_from(
&mut proof_reader,
Expand Down Expand Up @@ -270,9 +269,11 @@ impl<'a, Cfg: GKREngine> Verifier<'a, Cfg> {
let mut transcript = Cfg::TranscriptConfig::new();
let mut cursor = Cursor::new(&proof.bytes);

if !self.bind_and_check_public_inputs(&mut cursor, public_input, &mut transcript) {
return false;
// Bind public input to the FS transcript to prevent malleability attacks
for v in public_input {
transcript.append_field_element(v);
}

let commitment = self.pre_gkr(&mut cursor, circuit, &mut transcript, proving_time_mpi_size);

let (mut verified, mut challenge_x, mut challenge_y, claim_x, claim_y) = self.gkr(
Expand Down Expand Up @@ -316,8 +317,9 @@ impl<'a, Cfg: GKREngine> Verifier<'a, Cfg> {
let mut transcript = Cfg::TranscriptConfig::new();
let mut cursor = Cursor::new(&proof.bytes);

if !self.bind_and_check_public_inputs(&mut cursor, public_input, &mut transcript) {
return false;
// Bind public input to the FS transcript to prevent malleability attacks
for v in public_input {
transcript.append_field_element(v);
}

let commitment = self.pre_gkr(&mut cursor, circuit, &mut transcript, proving_time_mpi_size);
Expand Down Expand Up @@ -347,6 +349,7 @@ impl<'a, Cfg: GKREngine> Verifier<'a, Cfg> {
verified
}
}

impl<Cfg: GKREngine> Verifier<'_, Cfg> {
#[allow(clippy::too_many_arguments)]
fn get_pcs_opening_from_proof_and_verify(
Expand Down Expand Up @@ -382,32 +385,4 @@ impl<Cfg: GKREngine> Verifier<'_, Cfg> {

verified
}
fn bind_and_check_public_inputs(
&self,
cursor: &mut Cursor<&Vec<u8>>,
public_input: &[<Cfg::FieldConfig as FieldEngine>::SimdCircuitField],
transcript: &mut Cfg::TranscriptConfig,
) -> bool {
// Bind public input to the FS transcript to prevent malleability attacks
let mut proof_public_inputs = Vec::with_capacity(public_input.len());

for _ in 0..public_input.len() {
match <Cfg::FieldConfig as FieldEngine>::SimdCircuitField::deserialize_from(
&mut *cursor,
) {
Ok(v) => proof_public_inputs.push(v),
Err(_) => return false,
}
}
// Check equality
if proof_public_inputs != public_input {
return false;
}

// Now bind the inputs
for v in &proof_public_inputs {
transcript.append_field_element(v);
}
true
}
}
Loading