fix: replace enumerate with (str, Enum)#241
Open
fkuefler wants to merge 2 commits intoPolymarket:mainfrom
Open
fix: replace enumerate with (str, Enum)#241fkuefler wants to merge 2 commits intoPolymarket:mainfrom
fkuefler wants to merge 2 commits intoPolymarket:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a typo where OrderType and AssetType classes were incorrectly inheriting from the built-in enumerate function instead of the Enum class. The fix replaces this with proper (str, Enum) inheritance and adds __str__() overrides to maintain backward compatibility with existing code that expects enum values to serialize as strings.
- Fixed incorrect inheritance from
enumeratefunction to proper(str, Enum)pattern - Added
__str__()method override to both enums to return their string values - Imported the
Enumclass from theenummodule
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Why dont push and merge this PR as soon as possible? This is very important! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a typo where OrderType and AssetType were incorrectly inheriting from the enumerate function. It replaces this with proper (str, Enum) inheritance to satisfy type checkers while maintaining backward compatibility.
Description
Inheriting from enumerate (???) caused static type checkers like Pylance to incorrectly flag class attributes as strings rather than instances of their class. To fix this I used (str, Enum) inheritance with a str override so that members compare equal to raw strings and existing code doesn't break.
Types of changes
Status
[WIP]if necessary (changes not yet made).Note
Corrects enum definitions to satisfy type checkers and maintain string compatibility.
enumerateinheritance withstr, EnumforOrderTypeandAssetType__str__methods returning.valuefor both enumsEnumand update references where default enum values are usedWritten by Cursor Bugbot for commit 55fe98b. This will update automatically on new commits. Configure here.