Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Apply paper-toast mixin for custom styling - #106

Open
jadjoubran wants to merge 1 commit into
PolymerElements:masterfrom
jadjoubran:patch-1
Open

Apply paper-toast mixin for custom styling#106
jadjoubran wants to merge 1 commit into
PolymerElements:masterfrom
jadjoubran:patch-1

Conversation

@jadjoubran

@jadjoubran jadjoubran commented Feb 25, 2018

Copy link
Copy Markdown

Fixes #107

@valdrinkoshi valdrinkoshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @jadjoubran, mind filing an issue as per our contributing guidelines where to discuss the feature/issue, and link it in this PR description?

Ideally I'd prefer avoiding new mixins as the user might apply styles on properties that are required to keep paper-toast functioning (e.g. transition), and rather add new custom css properties where needed.

@jadjoubran

Copy link
Copy Markdown
Author

@valdrinkoshi done, thanks!
Sorry about not filing an issue first

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants