Skip to content

refactor(api): remove dead WithHTTPClient option (POS-109) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsollazzo merged 1 commit into from
Jul 8, 2026
Merged

refactor(api): remove dead WithHTTPClient option (POS-109) #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions internal/api/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ type Client struct {
// Option customizes a Client.
type Option func(*Client)

// WithHTTPClient replaces the underlying *http.Client (e.g. for a custom
// transport). The caller owns the timeout configuration.
func WithHTTPClient(h *http.Client) Option { return func(c *Client) { c.http = h } }

// WithSleep replaces the backoff sleep function — a test seam so retry tests
// assert waits instead of serving them.
func WithSleep(fn func(time.Duration)) Option { return func(c *Client) { c.sleep = fn } }
Expand Down