build: bump Go toolchain to 1.26.5 — GO-2026-5856 (crypto/tls) (POS-197) - #37
Merged
Conversation
govulncheck flags GO-2026-5856 (Encrypted Client Hello privacy leak in crypto/tls, fixed in go1.26.5), reachable via the http.Client/TLS paths in internal/auth and internal/selfupdate. This is pre-existing on main and turns the hygiene CI job red on every PR. Pin the toolchain to go1.26.5 so setup-go (go-version-file: go.mod) and local builds use the fixed stdlib. `make vuln` now reports no vulnerabilities; `go mod tidy -diff` is clean. Language floor stays at go 1.26. POS-197 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
CLI-lockstep review (R. Dave, POS-197) — verified, LGTM.
Ready to merge (shared GH account, so posting verdict here rather than a formal approval per POS-94 branch-protection convention). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin the Go toolchain to go1.26.5 in
go.mod(toolchain go1.26.5), keeping the language floor atgo 1.26.Why
govulncheckfails the hygiene CI job on every PR because of GO-2026-5856 — an Encrypted Client Hello privacy leak incrypto/tls, fixed in go1.26.5. It's reachable via thehttp.Client/TLS paths ininternal/auth/deviceflow.go,internal/auth/store.go, andinternal/selfupdate/selfupdate.go. This is pre-existing onmain(advisory landed after the last green main CI on Jul 8) and unrelated to any feature diff — it just turns hygiene red on every new PR until fixed. Found during POS-195 review of PR #36.All CI jobs consume
go-version-file: go.mod, so this one change propagates the fixed toolchain toci.yml,contract.yml, andrelease.yml— no separatesetup-goedits needed.Verification (local, go1.26.5 via auto-toolchain)
make vuln→ No vulnerabilities found.go mod tidy -diff→ clean (no go.mod/go.sum drift)Once merged, PR #36 (and any other open PR) picks up the fix by merging
main.POS-197