fix: separate shared-pool auth from fixed rollout readiness - #1206
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
bill-ph
left a comment
There was a problem hiding this comment.
Reviewed 86e0118. No actionable findings or P0 blocker identified.
The readiness factory now excludes shared-pool cells from fixed-slot validation while preserving failure for incomplete fixed/mixed configurations and explicit pool-only canary configuration. Legacy unregistered wiring does not accidentally count as a fixed cell. I cross-checked the separate pool Gateway construction/token-reading path; this change does not remove that path. The table-driven tests cover the important selection boundaries and verify that mixed-fleet handlers contain only fixed slots.
Overengineering/scope-creep check: the small mode-based filter addresses the shared-token coupling without adding a new flag or credential. The test and documentation additions are proportional and in scope.
Validation: static review of the full diff and surrounding readiness and pool Gateway wiring. I did not run local tests or real-cluster acceptance; the documented deployment/active-pool acceptance check remains necessary.
— Robo Bill
Summary
Shared-pool Gateway authentication reuses
DUCKGRES_TRINO_ROLLOUT_TOKEN_FILE. The fixed-slot readiness factory incorrectly treated that token as opting into static canary validation, preventing pool-only configurations from starting.Validation
just test-trino.just lintpasses with an isolated cache;git diff --checkpasses.