Conversation
Pull Request Test Coverage Report for Build 6492285293
💛 - Coveralls |
|
I would add the sentence: |
Habbie
left a comment
There was a problem hiding this comment.
and please look at Klaus' comment, thanks!
|
@Habbie I addressed the review comments myself and updated the PR. |
miodvallat
left a comment
There was a problem hiding this comment.
Don't forget to add a signed-off line to your commit (maybe squash?)
This is because the original submitter did not sign off (in the first commit), as that was not a requirement at the time. I could squash all commits and remove the submitter as the author, but that feels wrong. |
|
But you can sign-off for the original author. |
If a zone is operated with different nameserver software than PowerDNS and ALIAS is used it could result in an out-of-sync sencondary. Signed-off-by: Arsen Stasic <arsen.stasic@gmail.com>
If a zone is operated with different nameserver software than PowerDNS and ALIAS is used it could result in an out-of-sync sencondary.
Short description
Checklist
I have: