Skip to content

Update alias.rst#13360

Merged
miodvallat merged 3 commits intoPowerDNS:masterfrom
stasic:patch-5
Mar 6, 2026
Merged

Update alias.rst#13360
miodvallat merged 3 commits intoPowerDNS:masterfrom
stasic:patch-5

Conversation

@stasic
Copy link
Contributor

@stasic stasic commented Oct 12, 2023

If a zone is operated with different nameserver software than PowerDNS and ALIAS is used it could result in an out-of-sync sencondary.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6492285293

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 47 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.357%

Files with Coverage Reduction New Missed Lines %
pdns/sstuff.hh 1 60.24%
pdns/dbdnsseckeeper.cc 2 85.61%
pdns/iputils.hh 2 73.66%
pdns/misc.cc 2 61.32%
pdns/channel.hh 3 55.97%
pdns/dnsdistdist/dnsdist-healthchecks.cc 3 55.31%
pdns/stubresolver.cc 3 81.63%
pdns/tcpiohandler.cc 3 66.83%
pdns/test-distributor_hh.cc 3 88.66%
pdns/dnsdist.cc 5 71.05%
Totals Coverage Status
Change from base Build 6486035458: -0.02%
Covered Lines: 102357
Relevant Lines: 151170

💛 - Coveralls

@Habbie Habbie added this to the auth-4.9.0 milestone Oct 12, 2023
@klaus-nicat
Copy link
Contributor

I would add the sentence:
"To keep secondary nameservers up2date with the ALIAS target, you have to periodically retransfer the zone from PowerDNS, to force ALIAS-resolving during AXFR. This can be done either "dumb", for example every minute, or implement some "out of band" logic to retransfer zones only if the ALIAS target actually changed."

@Habbie Habbie modified the milestones: auth-4.9.0, auth-helpneeded Jan 23, 2024
Habbie
Habbie previously requested changes Mar 21, 2024
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please look at Klaus' comment, thanks!

@pieterlexis
Copy link
Contributor

@Habbie I addressed the review comments myself and updated the PR.

@Habbie Habbie dismissed their stale review March 6, 2026 11:29

is done

miodvallat
miodvallat previously approved these changes Mar 6, 2026
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a signed-off line to your commit (maybe squash?)

@pieterlexis
Copy link
Contributor

Don't forget to add a signed-off line to your commit (maybe squash?)

This is because the original submitter did not sign off (in the first commit), as that was not a requirement at the time. I could squash all commits and remove the submitter as the author, but that feels wrong.

@miodvallat
Copy link
Contributor

But you can sign-off for the original author.

stasic and others added 2 commits March 6, 2026 12:53
If a zone is operated with different nameserver software than PowerDNS and ALIAS is used it could result in an out-of-sync sencondary.

Signed-off-by: Arsen Stasic <arsen.stasic@gmail.com>
@miodvallat miodvallat merged commit 0c2bba9 into PowerDNS:master Mar 6, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants