rec: allow overriding remote address from preoutquery()#15808
rec: allow overriding remote address from preoutquery()#15808elenril wants to merge 2 commits intoPowerDNS:masterfrom
Conversation
Pull Request Test Coverage Report for Build 17795654203Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Please have some patience. We are certainly considering this, but first we need to finish the 5.3.0 release. |
|
Please have some patience. We are certainly considering this, but first we need to finish the 5.3.0 release.
No problem, I did expect to wait until the release, and I've been on vacation anyway.
|
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
b884bcc to
1037335
Compare
|
I rebased the code and added a fix for when the new remote is TCP and port 853, it should switch to DoT if needed. |
|
As I suspected, there's an issue with the nsspeed bookkeeping: the original IP stays in the table at 0ms, while the updated IP gets an entry > 0ms. The speed based selection mechanism then keeps selecting the fast 0ms entry, which is never updated, basically breaking the mechanism that selects the fastest nameserver. |
Short description
The LUA
preoutquery()hook can now modifydq.remoteaddrto override the remote server to query.Fixes #6798
Checklist
I have: