ci: Force python formatting with ruff#16477
Open
pieterlexis wants to merge 2 commits intoPowerDNS:masterfrom
Open
ci: Force python formatting with ruff#16477pieterlexis wants to merge 2 commits intoPowerDNS:masterfrom
pieterlexis wants to merge 2 commits intoPowerDNS:masterfrom
Conversation
d2473b3 to
f8f680e
Compare
Contributor
|
Will you update |
Contributor
Author
Not yet, but it could :). Although it is specifically for C++. formatting yourself is as simple as install |
Collaborator
|
From my experience with a rather large project, I'd like to offer two unsolicited pieces of advice:
a pyproject.toml config would be: |
f8f680e to
af543a1
Compare
Contributor
Author
|
Updated the PR to use ruff (which is indeed fast) |
af543a1 to
c821d8d
Compare
c821d8d to
c0f94dc
Compare
Member
|
I like it, I think the next steps are:
|
Contributor
Author
Let's discuss this with the team during a team meeting. I've added it to the list of topics |
c0f94dc to
1089bd8
Compare
1089bd8 to
7a663e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This enforces proper formatting of all the python files in the repository.
Checklist
I have: