codeql PEP8 first argument should be self#16518
Draft
jsoref wants to merge 27 commits intoPowerDNS:masterfrom
Draft
codeql PEP8 first argument should be self#16518jsoref wants to merge 27 commits intoPowerDNS:masterfrom
jsoref wants to merge 27 commits intoPowerDNS:masterfrom
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…callback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
….callback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…Callback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…Callback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…Callback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…gPathCallback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…llback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…hableCallback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…entAddr2Callback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…entAddr1Callback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…lback Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
miodvallat
approved these changes
Nov 17, 2025
Contributor
miodvallat
left a comment
miodvallat
left a comment
There was a problem hiding this comment.
As someone who always types slef when trying to type self, I am strongly opposed to that PR.
rgacogne
requested changes
Nov 17, 2025
| """ | ||
| _verboseMode = True | ||
|
|
||
| def NoSVCCallback(request): |
Member
There was a problem hiding this comment.
I don't think this is the right fix, shouldn't these methods become static instead?
Contributor
Author
There was a problem hiding this comment.
I didn't try to reason through these because it looked like they were passed through a function callback. It required more python alertness than I have in the morning. -- Someone who's comfortable w/ python should weigh in.
Contributor
Author
There was a problem hiding this comment.
ok, I'm convinced it should be a staticmethod.
I'll do this from home.
| """ | ||
|
|
||
| def callback(request, headers, fromQueue, toQueue): | ||
| def callback(self, headers, fromQueue, toQueue): |
Member
There was a problem hiding this comment.
Same here, I think they should be static methods.
jsoref
commented
Nov 17, 2025
| return None | ||
|
|
||
| def from_wire(cls, otype, wire, current, olen): | ||
| def from_wire(self, otype, wire, current, olen): |
Contributor
Author
There was a problem hiding this comment.
Ok, I think this is the correct change:
Suggested change
| def from_wire(self, otype, wire, current, olen): | |
| @classmethod | |
| def from_wire(cls, otype, wire, current, olen): |
| """ | ||
| _verboseMode = True | ||
|
|
||
| def NoSVCCallback(request): |
Contributor
Author
There was a problem hiding this comment.
ok, I'm convinced it should be a staticmethod.
I'll do this from home.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
codeql complains (per PEP8) when the first argument to methods is not
self: https://github.com/check-spelling-sandbox/pdns/security/quality/rules/py%2Fnot-named-selfChecklist
I have: