auth: Fix a bunch of issues when building with meson#16734
auth: Fix a bunch of issues when building with meson#16734rgacogne wants to merge 4 commits intoPowerDNS:masterfrom
meson#16734Conversation
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
Turns out `powerdns` is an Arch Linux thing. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
…`meson` Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
| input: man_pages, | ||
| output: generated_man_pages, | ||
| install: true, | ||
| # wrong for ixfrdist.yml.5 but I don't know how to handle that |
There was a problem hiding this comment.
Well can't you use the endswith trick above here too?
There was a problem hiding this comment.
I tried but I couldn't find how to apply a different treatment to the generated files, since a single command generates several of them. I attempted to not install from custom_target but to iterate over the generated files, calling install_man for every one of them with the correct directory, but that does not work if the files are not present in the build directory yet (which defeats the point).
There was a problem hiding this comment.
The ternary operator does the trick to install the ixfrdist.yml.5 in the correct location
There was a problem hiding this comment.
You are looking at the wrong location in the file, your fix (applied in this PR) works for the case where the man pages are present in the source directory (release tarball) but this case is when they aren't.
Pull Request Test Coverage Report for Build 21073006167Details
💛 - Coveralls |
Short description
This PR contains patches submitted by @RvdE in #13987 and one from @zeha submitted in #16702.
It fixes the issues reported in #13987 in my tests, but I couldn't reproduce the
Unable to load module './libgpgsqlbackend.so': ./libgpgsqlbackend.so: Undefined symbol "_ZTV11GSQLBackend"so it's probably not fixed.I did not pick up the GSQL related changed from #16702 because 1/ I couldn't check the fix because I cannot reproduce the issue 2/ they clearly do not work when more than one GSQL-based module is linked statically into the
pdns_serverbinary, as reported by our CI.Checklist
I have: