feat(dnsdist): Add instance field to OT Trace messages#16741
Open
pieterlexis wants to merge 1 commit intoPowerDNS:masterfrom
Open
feat(dnsdist): Add instance field to OT Trace messages#16741pieterlexis wants to merge 1 commit intoPowerDNS:masterfrom
pieterlexis wants to merge 1 commit intoPowerDNS:masterfrom
Conversation
omoerbeek
reviewed
Jan 20, 2026
Pull Request Test Coverage Report for Build 21166342258Details
💛 - Coveralls |
omoerbeek
added a commit
to omoerbeek/pdns
that referenced
this pull request
Jan 22, 2026
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
3d83e92 to
d24cb48
Compare
d24cb48 to
21a5a5d
Compare
omoerbeek
added a commit
that referenced
this pull request
Feb 5, 2026
rec: harmonize with dnsdist PR #16741 wrt OpenTelemetry instance name
0082e45 to
941950c
Compare
941950c to
c65cb21
Compare
And drop hostname as a result.
c65cb21 to
08ba939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR ensures there is an
instancefield set to the DNSDist server id in OpenTelemetry Trace messages.Checklist
I have: