Skip to content

feat(dnsdist): Add instance field to OT Trace messages#16741

Open
pieterlexis wants to merge 1 commit intoPowerDNS:masterfrom
pieterlexis:dnsdist-ot-serverid-instance
Open

feat(dnsdist): Add instance field to OT Trace messages#16741
pieterlexis wants to merge 1 commit intoPowerDNS:masterfrom
pieterlexis:dnsdist-ot-serverid-instance

Conversation

@pieterlexis
Copy link
Contributor

Short description

This PR ensures there is an instance field set to the DNSDist server id in OpenTelemetry Trace messages.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21166342258

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10936 unchanged lines in 105 files lost coverage.
  • Overall coverage decreased (-4.9%) to 67.847%

Files with Coverage Reduction New Missed Lines %
pdns/protozero-trace.hh 1 67.77%
pdns/burtle.hh 2 97.59%
pdns/channel.hh 2 47.48%
pdns/dns.cc 2 87.39%
pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc 2 0.0%
pdns/dnsdistdist/dnsdist-lua.hh 2 0.0%
pdns/dnsdistdist/dnsdist-opentelemetry.cc 2 94.47%
pdns/epollmplexer.cc 2 83.85%
pdns/libssl.hh 2 0.0%
pdns/pollmplexer.cc 2 84.31%
Totals Coverage Status
Change from base Build 21142287425: -4.9%
Covered Lines: 105792
Relevant Lines: 146927

💛 - Coveralls

omoerbeek added a commit to omoerbeek/pdns that referenced this pull request Jan 22, 2026
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
@pieterlexis pieterlexis force-pushed the dnsdist-ot-serverid-instance branch from 3d83e92 to d24cb48 Compare January 26, 2026 10:28
@pieterlexis pieterlexis force-pushed the dnsdist-ot-serverid-instance branch from d24cb48 to 21a5a5d Compare February 5, 2026 09:10
omoerbeek added a commit that referenced this pull request Feb 5, 2026
rec: harmonize with dnsdist PR #16741 wrt OpenTelemetry instance name
@pieterlexis pieterlexis force-pushed the dnsdist-ot-serverid-instance branch 2 times, most recently from 0082e45 to 941950c Compare February 23, 2026 11:13
@rgacogne rgacogne added this to the dnsdist-2.2.0 milestone Feb 25, 2026
@pieterlexis pieterlexis force-pushed the dnsdist-ot-serverid-instance branch from 941950c to c65cb21 Compare March 3, 2026 10:21
@pieterlexis pieterlexis force-pushed the dnsdist-ot-serverid-instance branch from c65cb21 to 08ba939 Compare March 6, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants