Skip to content

auth: include serial (that is, SOA record) while sending a notify #16886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
omoerbeek wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −2
Draft

auth: include serial (that is, SOA record) while sending a notify #16886

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab7a10c
auth: include serial with notify
omoerbeek Sep 22, 2025
946c94a
Edit notified serial if relevant
omoerbeek Sep 24, 2025
56b9ed7
Pass ueber object to avoid creating too many instances
omoerbeek Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pdns/auth-primarycommunicator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,17 @@ void CommunicatorClass::sendNotification(int sock, const ZoneName& domain, const
pwriter.getHeader()->id = notificationId;
pwriter.getHeader()->aa = true;

if (tsigkeyname.empty() == false) {

if (SOAData soaData; ueber->getSOAUncached(domain, soaData)) {
DNSSECKeeper dnssecKeeper(ueber);
auto editedSOA = makeEditedDNSZRFromSOAData(dnssecKeeper, soaData, DNSResourceRecord::ANSWER);
auto soaContent = editedSOA.dr.getContent();
pwriter.startRecord(domain.operator const DNSName&(), QType::SOA, soaData.ttl, QClass::IN, DNSResourceRecord::ANSWER);
soaContent->toPacket(pwriter);
pwriter.commit();
}

if (!tsigkeyname.empty()) {
if (!ueber->getTSIGKey(tsigkeyname, tsigalgorithm, tsigsecret64)) {
g_log << Logger::Error << "TSIG key '" << tsigkeyname << "' for domain '" << domain << "' not found" << endl;
return;
Expand All @@ -324,7 +334,7 @@ void CommunicatorClass::sendNotification(int sock, const ZoneName& domain, const
addTSIG(pwriter, trc, tsigkeyname, tsigsecret, "", false);
}

if (sendto(sock, &packet[0], packet.size(), 0, (struct sockaddr*)(&remote), remote.getSocklen()) < 0) {
if (sendto(sock, packet.data(), packet.size(), 0, reinterpret_cast<const struct sockaddr*>(&remote), remote.getSocklen()) < 0) { // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast) It's the API
throw ResolverException("Unable to send notify to " + remote.toStringWithPort() + ": " + stringerror());
}
}
Expand Down
Loading