dnsdist: Add recvmmsg support for backend responses#16932
Draft
rgacogne wants to merge 1 commit intoPowerDNS:masterfrom
Draft
dnsdist: Add recvmmsg support for backend responses#16932rgacogne wants to merge 1 commit intoPowerDNS:masterfrom
recvmmsg support for backend responses#16932rgacogne wants to merge 1 commit intoPowerDNS:masterfrom
Conversation
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
| for (size_t idx = 0; idx < vectSize; idx++) { | ||
| recvData[idx].packet.resize(initialBufferSize + 1); | ||
| // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) | ||
| fillMSGHdr(&msgVec[idx].msg_hdr, &recvData[idx].iov, &recvData[idx].cbuf, sizeof(recvData[idx].cbuf), reinterpret_cast<char*>(recvData[idx].packet.data()), initialBufferSize + 1, &recvData[idx].remote); |
Check notice
Code scanning / CodeQL
Sizeof with side effects Note
miodvallat
reviewed
Feb 26, 2026
| for (size_t idx = 0; idx < vectSize; idx++) { | ||
| recvData[idx].packet.resize(initialBufferSize + 1); | ||
| // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) | ||
| fillMSGHdr(&msgVec[idx].msg_hdr, &recvData[idx].iov, &recvData[idx].cbuf, sizeof(recvData[idx].cbuf), reinterpret_cast<char*>(recvData[idx].packet.data()), initialBufferSize + 1, &recvData[idx].remote); |
Contributor
There was a problem hiding this comment.
The bot complains that recvData[idx] is a function call in disguise. The following ought to silence it:
Suggested change
| fillMSGHdr(&msgVec[idx].msg_hdr, &recvData[idx].iov, &recvData[idx].cbuf, sizeof(recvData[idx].cbuf), reinterpret_cast<char*>(recvData[idx].packet.data()), initialBufferSize + 1, &recvData[idx].remote); | |
| fillMSGHdr(&msgVec[idx].msg_hdr, &recvData[idx].iov, &recvData[idx].cbuf, sizeof(cmsgbuf_aligned /*recvData[idx].cbuf*/), reinterpret_cast<char*>(recvData[idx].packet.data()), initialBufferSize + 1, &recvData[idx].remote); |
Contributor
There was a problem hiding this comment.
Ah yes, that ought to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Needs testing, especially performance testing, documentation and perhaps even a switch in the configuration.
Closes #16625
Checklist
I have: