Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring the S3 storage class in the S3 backend. This allows users to specify storage classes like STANDARD_IA, GLACIER, etc., when storing objects to optimize costs based on access patterns.
- Added
StorageClassfield to theOptionsstruct with YAML configuration support - The storage class is now passed to the minio client's
PutObjectOptionswhen storing objects
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for the contribution, it looks good! Could you provide more information about how the test suite fails? |
Contributor
Author
|
Thank you for the review :) I've taken a deeper look into the test issue. The failed tests are related to the minio test container. The testcontainers library creates the minio container in my rootless podman instance, but doesn't start it. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to be able to set the storage class in lightningstream for S3. For this reason I've added the class in the "doStoreReader" method. It should be fine to set it for every call in simpleblob, as the minio-go client takes care of handling an empty string (according to https://github.com/minio/minio-go/blob/master/api-put-object.go#L200).