Bug fixes + Feature implementations#1
Open
nectarboy wants to merge 32 commits intoPowerlated:masterfrom
Open
Conversation
* A sequence using bank 0 no longer causes an exception * Mono mode is now set to true by default, i think this is the correct behavior
* Fixed pitch bend sign extension * Tie commands now stop all of a track's active channels (on or off)
…e 2 opcodes work with them atm because laziness)
…d restarting ssar playback button
… popping with finetune pitch
…mple instrument play at the same time
…er 0 wasnt being detected)
a note with duration 0, mono or not, will have the note play until its sample ends (or forever if the sample loops) (source: Nintendo's own documentation) a note with duration 0 when mono, will have the same as above occur, but will also have the track rest until that note channel, and no other channel, ends. this fixes the NSMB Wanted minigame voice clip echoes [NCS_SE_MGT_LUIGI_RIGHT_M0 (ID: 75) and etc]
…e in tie-in notes)
…e the note play with the wrong program [SM64: NCS_SE_PT_METAL_HIP_ATTACK (ID: 166)]
…LOON_JUMP (ID: 190)]
… fixes numerous issues caused by the state of the sequence changing after the note command is sent, leading to the notes being played wrong.
…g them [SM64: NCS_SE_PT_STEP_HIT (ID: 182)] Source: pret decomp; SND_seq.c
…AP_W (ID: 183), NCS_SE_VO_RET_NOCAP_L (ID: 119)]
…nyone can be a ripper™!
Bug fixes + Feature implementations
…aying at the same time
…S: SE_M106_007], removed DX suffix from the project title
Merge willy-fixes --> master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This WIP pull request aims to fix bugs and implement missing features in the player, as well as extend existing functionality mostly to allow SSAR playback.
Implemented features:
the ability to playback SSARs, as well as several features that were needed to correctly play most SSAR sequences, including tie, mono, loop, portamento, etc, have been implemented.
Bug fixes:
many bugs have been fixed, and the player has been tested with against Nintendo's SoundPlayer SDK tool to ensure playback is as accurate as possible (as far as i can percieve).
Frontend features:
the frontend has been given the ability to playback and export SSAR sequences.
What still needs fixing:
The piano preview on the side doesn't respond to input anymore for some reason
The fullscreen preview doesn't work after a while, unsure if this is a result of my changes
The code needs a bit of clean up
The existing pan delay feature caused issues with some sounds so it is disabled for now
Missing features (PSG and white noise, LFO volume and pan) still need to be implemented.